Fixing desired capabilities and find element deprecation #2050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrTeale
changed the title
Contributor
Author
|
This is currently causing some tests to be flaky. Looking into why a bit more so until then, PLEASE DO NOT MERGE. If you have any questions or feedback, let me know. |
alexcjohnson
approved these changes
May 20, 2022
Collaborator
There was a problem hiding this comment.
💃 Looks great, thanks for the contribution @MrTeale
The table-server-test failure here is nothing to do with your changes, it's an intermittent failure we've seen recently, so far we haven't figured out the origin but it shouldn't block your PR.
(approved pending the two comments above plus a changelog entry as you noted)
Contributor
Author
|
Thanks @alexcjohnson! This should be ready to go now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #1870
When running the tests,
DeprecationWarning: desired_capabilities has been deprecated, please pass in a Service objectis shown.There was also another similar message that has been dealt with in this PR:
DeprecationWarning: find_element_by_* commands are deprecated. Please use find_element() instead. This has been solved byfind_elementandfind_elementsnow taking an attribute keyword, as a string, for the type of selector that is being used. default is set toCSS_SELECTORas that's what historicallyfind_elementwas solely for.Contributor Checklist
desired_capabilitiesdeprecation warningfind_element_by_*deprecation warningCHANGELOG.md